AG-112 API overovanie #352

celuchmarek · 2023-12-06T12:12:53Z

No description provided.

celuchmarek · 2023-12-06T12:29:46Z

@jsuchal má to v sebe rovnaké info ako to API v3 na upvs cep. Hlavný rozdiel je tu v kódoch. Napr. kód výsledku overenia alebo kódy typu podpisu. UPVS má nejaký číselník a DSS má nejaký. Bolo by to treba namapovať a nie je to úplne 1:1, lebo na UPVS sa ešte rieši, či to je slovenské a podobne. Nevyše, na upvs majú aj field legislativnyTypPodpisu. Na to by trebalo zase nejakú logiku, čo popozerá kvalifikácie a nejaké atribúty certifikátov a rozhodne.

Takže kód výsledky a typu podpisu a pečiatky som nechal podľa DSS aj s DSS readable (QESig, QTSA a podobne).

API som robil podľa toho v3, tak sú tie fieldy v slovenčine, ale nejako sa mi to nepáči. Môžem ešte prehodiť do EN, pretože tak čí tak to nie je 1:1 API s v3 na upvs.

celuchmarek · 2023-12-06T12:31:31Z

Redacted example:

{
  "fileFormat": "ASiC_E",
  "signatures": [
    {
      "validaitonResult": {
        "code": 0,
        "description": "TOTAL_PASSED"
      },
      "signatureInfo": {
        "level": "XAdES_BASELINE_LTA",
        "claimedSigningTime": "2022-12-20T21:29:13 +0100",
        "isTimestamped": true,
        "timestampSigningTime": "2022-12-20T21:29:13 +0100",
        "signingCertificate": {
          "issuerDN": "CN=CA Disig QCA3, OU=ACA-307-2007-2, O=Disig a.s., OID.2.5.4.5=NTRSK-35975946, L=Bratislava, C=SK",
          "subjectDN": "C=SK, L=Bratislava, OID.2.5.4.5=NTRSK-30807484, O=Sociálna poisťovňa, CN=Sociálna poisťovňa",
          "serialNumber": "81308597867087210236466",
          "productionTime": "2022-12-20T21:29:13 +0100",
          "notBefore": "2019-07-03T15:21:51 +0200",
          "notAfter": "2023-07-02T15:21:51 +0200",
          "qualification": {
            "code": 1,
            "description": "QESeal"
          }
        },
        "timestamps": [
          {
            "issuerDN": "CN=SNCA4, O=Narodna agentura pre sietove a elektronicke sluzby, OID.2.5.4.97=NTRSK-42156424, OU=SNCA, C=SK",
            "subjectDN": "CN=NASES Time Stamp Authority 2, O=Národná agentúra pre sieťové a elektronické služby, OID.2.5.4.97=NTRSK-42156424, OU=SNCA, C=SK",
            "serialNumber": "21220574739238913835018",
            "productionTime": "2022-12-20T21:29:13 +0100",
            "notBefore": "2021-04-15T13:31:24 +0200",
            "notAfter": "2026-04-14T13:31:24 +0200",
            "qualification": {
              "code": 0,
              "description": "QTSA"
            },
            "timestampType": "SIGNATURE_TIMESTAMP"
          },
          {
            "issuerDN": "CN=Timestamp CA, OID.2.5.4.5=202101, OU=QTSP: FPS Policy and Support - BOSA (NTRBE-0671516647), O=Kingdom of Belgium - Federal Government, L=Brussels, C=BE",
            "subjectDN": "CN=Timestamp Unit, OID.2.5.4.5=202102, OU=QTSP: FPS Policy and Support - BOSA (NTRBE-0671516647), O=Kingdom of Belgium - Federal Government, L=Brussels, C=BE",
            "serialNumber": "93373602251984153477303393981460392060238324425",
            "productionTime": "2023-12-06T18:02:31 +0100",
            "notBefore": "2021-03-16T10:40:24 +0100",
            "notAfter": "2027-03-16T10:40:24 +0100",
            "qualification": {
              "code": 0,
              "description": "QTSA"
            },
            "timestampType": "ARCHIVE_TIMESTAMP"
          }
        ],
        "signedObjectsIds": [
          "D-CE70D85E47F41DE68616A3695FE7569BF8F7409F052B74AE0356663393A68D8A",
          "D-1190915437AA39812C091DA0A4473DC0821D99CC3F127A01AB53074FDBDF8526"
        ]
      }
    },
    {
      "validaitonResult": {
        "code": 0,
        "description": "TOTAL_PASSED"
      },
      "signatureInfo": {
        "level": "XAdES_BASELINE_LTA",
        "claimedSigningTime": "2023-12-06T10:54:14 +0100",
        "isTimestamped": true,
        "timestampSigningTime": "2023-12-06T10:54:19 +0100",
        "signingCertificate": {
          "issuerDN": "CN=SVK eID ACA2, O=Disig a.s., OID.2.5.4.97=NTRSK-35975946, L=Bratislava, C=SK",
          "subjectDN": "OID.2.5.4.5=PNOSK-1234567890, C=SK, L=Sečovská Polianka, OID.2.5.4.4=Ceľuch, OID.2.5.4.42=Marek, CN=Marek Ceľuch",
          "serialNumber": "30136665461343719048771",
          "productionTime": "2023-12-06T10:54:14 +0100",
          "notBefore": "2022-06-20T10:22:29 +0200",
          "notAfter": "2025-06-17T01:00:22 +0200",
          "qualification": {
            "code": 0,
            "description": "QESig"
          }
        },
        "timestamps": [
          {
            "issuerDN": "CN=Timestamp CA, OID.2.5.4.5=202101, OU=QTSP: FPS Policy and Support - BOSA (NTRBE-0671516647), O=Kingdom of Belgium - Federal Government, L=Brussels, C=BE",
            "subjectDN": "CN=Timestamp Unit, OID.2.5.4.5=202102, OU=QTSP: FPS Policy and Support - BOSA (NTRBE-0671516647), O=Kingdom of Belgium - Federal Government, L=Brussels, C=BE",
            "serialNumber": "93373602251984153477303393981460392060238324425",
            "productionTime": "2023-12-06T10:54:19 +0100",
            "notBefore": "2021-03-16T10:40:24 +0100",
            "notAfter": "2027-03-16T10:40:24 +0100",
            "qualification": {
              "code": 0,
              "description": "QTSA"
            },
            "timestampType": "SIGNATURE_TIMESTAMP"
          },
          {
            "issuerDN": "CN=Timestamp CA, OID.2.5.4.5=202101, OU=QTSP: FPS Policy and Support - BOSA (NTRBE-0671516647), O=Kingdom of Belgium - Federal Government, L=Brussels, C=BE",
            "subjectDN": "CN=Timestamp Unit, OID.2.5.4.5=202102, OU=QTSP: FPS Policy and Support - BOSA (NTRBE-0671516647), O=Kingdom of Belgium - Federal Government, L=Brussels, C=BE",
            "serialNumber": "93373602251984153477303393981460392060238324425",
            "productionTime": "2023-12-06T18:02:31 +0100",
            "notBefore": "2021-03-16T10:40:24 +0100",
            "notAfter": "2027-03-16T10:40:24 +0100",
            "qualification": {
              "code": 0,
              "description": "QTSA"
            },
            "timestampType": "ARCHIVE_TIMESTAMP"
          }
        ],
        "signedObjectsIds": [
          "D-CE70D85E47F41DE68616A3695FE7569BF8F7409F052B74AE0356663393A68D8A",
          "D-1190915437AA39812C091DA0A4473DC0821D99CC3F127A01AB53074FDBDF8526"
        ]
      }
    },
    {
      "validaitonResult": {
        "code": 0,
        "description": "TOTAL_PASSED"
      },
      "signatureInfo": {
        "level": "XAdES_BASELINE_LTA",
        "claimedSigningTime": "2023-12-06T10:57:07 +0100",
        "isTimestamped": true,
        "timestampSigningTime": "2023-12-06T18:02:31 +0100",
        "signingCertificate": {
          "issuerDN": "CN=SVK eID ACA2, O=Disig a.s., OID.2.5.4.97=NTRSK-35975946, L=Bratislava, C=SK",
          "subjectDN": "OID.2.5.4.5=PNOSK-1234567890, C=SK, L=Sečovská Polianka, OID.2.5.4.4=Ceľuch, OID.2.5.4.42=Marek, CN=Marek Ceľuch",
          "serialNumber": "30136665461343719048771",
          "productionTime": "2023-12-06T10:57:07 +0100",
          "notBefore": "2022-06-20T10:22:29 +0200",
          "notAfter": "2025-06-17T01:00:22 +0200",
          "qualification": {
            "code": 0,
            "description": "QESig"
          }
        },
        "timestamps": [
          {
            "issuerDN": "CN=Timestamp CA, OID.2.5.4.5=202101, OU=QTSP: FPS Policy and Support - BOSA (NTRBE-0671516647), O=Kingdom of Belgium - Federal Government, L=Brussels, C=BE",
            "subjectDN": "CN=Timestamp Unit, OID.2.5.4.5=202102, OU=QTSP: FPS Policy and Support - BOSA (NTRBE-0671516647), O=Kingdom of Belgium - Federal Government, L=Brussels, C=BE",
            "serialNumber": "93373602251984153477303393981460392060238324425",
            "productionTime": "2023-12-06T18:02:31 +0100",
            "notBefore": "2021-03-16T10:40:24 +0100",
            "notAfter": "2027-03-16T10:40:24 +0100",
            "qualification": {
              "code": 0,
              "description": "QTSA"
            },
            "timestampType": "SIGNATURE_TIMESTAMP"
          },
          {
            "issuerDN": "CN=Timestamp CA, OID.2.5.4.5=202101, OU=QTSP: FPS Policy and Support - BOSA (NTRBE-0671516647), O=Kingdom of Belgium - Federal Government, L=Brussels, C=BE",
            "subjectDN": "CN=Timestamp Unit, OID.2.5.4.5=202102, OU=QTSP: FPS Policy and Support - BOSA (NTRBE-0671516647), O=Kingdom of Belgium - Federal Government, L=Brussels, C=BE",
            "serialNumber": "93373602251984153477303393981460392060238324425",
            "productionTime": "2023-12-06T18:02:32 +0100",
            "notBefore": "2021-03-16T10:40:24 +0100",
            "notAfter": "2027-03-16T10:40:24 +0100",
            "qualification": {
              "code": 0,
              "description": "QTSA"
            },
            "timestampType": "ARCHIVE_TIMESTAMP"
          }
        ],
        "signedObjectsIds": [
          "D-CE70D85E47F41DE68616A3695FE7569BF8F7409F052B74AE0356663393A68D8A",
          "D-1190915437AA39812C091DA0A4473DC0821D99CC3F127A01AB53074FDBDF8526"
        ]
      }
    }
  ],
  "signedObjects": [
    {
      "id": "D-CE70D85E47F41DE68616A3695FE7569BF8F7409F052B74AE0356663393A68D8A",
      "mimeType": "text/xml",
      "filename": "form.xml"
    },
    {
      "id": "D-1190915437AA39812C091DA0A4473DC0821D99CC3F127A01AB53074FDBDF8526",
      "mimeType": "application/pdf",
      "filename": "OOP_kampan_2022_378_priloha.pdf"
    }
  ],
  "unsignedObjects": [
    {
      "mimeType": "text/xml",
      "filename": "Súbor bez názvu (1).xml"
    }
  ]
}

jsuchal · 2023-12-06T12:48:33Z

@celuchmarek suhlas, ze toto asi drzme english ked cele api je english.

este by ma zaujimalo ked das peciatku (taku tu dlhodobu) na nejaky dokument, ze co to ma vratit. tu vidim ze na podpise moze byt len jedna casova peciatka?

celuchmarek · 2023-12-06T12:55:53Z

Zle vidíš. Je to list, takže pečiatok tam môže byť hocikoľko. Ono sa len ten field volá takto singulárovo. Premenujem to celé do EN.

S archívnou pečiatkou by to malo vrátiť _LTA typ podpisu. Tú archívnu viem ísť nejakú pozrieť/vyskúšať, keďže to teraz súvisí aj s ďalším taskom. Zatiaľ si myslím, že tá archívna tam bude v osobitnom súbore, ale pri validácii by sa mala objaviť normálne medzi ostatnými čp per podpis, ale bude rovnaké u všetkých podpisov.

jsuchal · 2023-12-06T13:04:47Z

"datumACasCasovejPeciatkyPodpisuUtc": "Wed Dec 06 10:54:19 CET 2023", nevyzera ako list. ako list vidim len certifikaty podpisovych peciatok co vsak neobsahuje cas peciatky (len platnost certu), ci stale zle vidim?

jsuchal · 2023-12-06T13:06:51Z

Vracia to aj nepodpisane objekty? To mi pride take logicke, ze by som asi chcel, ze nech mi to ukaze cely obsah aj co tam je nepodpisane, aby som to nemusel rozoberat a parovat na 2x.

celuchmarek · 2023-12-06T14:17:20Z

@jsuchal updatol som v predošlom komente ten example. Pridal som teda productionTime pre každú TS aj pre podpis (aby to bola rovnaká štruktúra). V UPVS v3 to nie je, takže to zjavne nemá usecase. Tam majú iba čas prvej, čo ti hovorí, kedy to bolo podpísané. Reálne tie ďalšie ťa asi nezaujímajú. Tam skôr pozeráš na ich platnosť.

S vracaním objektov to je tricky. Ešte pred pár mesiacmi som testoval ten extractor.getSignedObjects a to vracalo aj nepodpísané objekty, ktoré ale boli podpísateľné - čiže žiadne manifesty a podobné štrukturálne veci. Ale tiež usecase na toto nepoznám, že by si mal v asicu nepodpísaný objekt.

jsuchal · 2023-12-06T14:55:55Z

Ale tiež usecase na toto nepoznám, že by si mal v asicu nepodpísaný objekt.

Ja poznam. Podvod :) Uvediem ta do omylu, ze som nieco uz podpisal a ty to podpises tiez.

celuchmarek · 2023-12-06T15:43:02Z

@jsuchal ok, pridal som explicitne aj zoznam nepodpisanych dokumentov v asicu. Edistol som example.

celuchmarek · 2023-12-06T17:09:33Z

@jsuchal Extendol som podpisy z XAdES_BASELINE_T a _B na XAdES_BASELINE_LTA level (pomocou Autogramu!) a pridali sa pečiatky do každého signature súboru s typom ARCHIVE_TIMESTAMP. Pridal som typ pečiatky aj do tohto response. Do signature súborov to uložilo aj revokačné dáta a certifikáty z celej reťaze. Pri _B podpise (bez pečiatky) to pridalo dve pečiatky - SIGNAURE_TIMESTAMP a ARCHIVE_TIMESTAMP. Zmenilo to level podpisu pri vyhodnotení (už LTA namiesto T), takže dobre.

Updatol som example vyššie.

src/main/java/digital/slovensko/autogram/server/dto/ValidationResponseBody.java

jsuchal

Vyzera to slubne, kukni ten preklep a este by mozno dokumentacia stala za vysvetlenie zopar fieldov.

src/main/resources/digital/slovensko/autogram/server/server.yml

jsuchal

Za mna dobre. Dajme to na pripomienky klientovi.

jsuchal · 2024-02-27T10:40:49Z

@celuchmarek tu sa ozvime klientovi a zaroven dava zmysel mozno toto mergnut a vyuzivat ako api pre dalsi produkt AVM.

celuchmarek added 5 commits November 29, 2023 08:28

validation api WIP

0acf083

validation api wip

02a7d4d

Merge branch 'main' into AG-112/api-overovanie

b9da4ab

add validation api

3d60dd0

minor changes

13bcd4e

celuchmarek requested a review from jsuchal December 6, 2023 12:33

celuchmarek added 3 commits December 6, 2023 14:30

translate the validaiton api response objects to english

ebf1d64

refactor, add production time to all ts and format datetimes

94cefd3

add productionTime to api description

2c583cf

add unsigned objects to response

847af55

add ts type to response

563a5f6

jsuchal reviewed Dec 6, 2023

View reviewed changes

src/main/java/digital/slovensko/autogram/server/dto/ValidationResponseBody.java Outdated Show resolved Hide resolved

jsuchal reviewed Dec 6, 2023

View reviewed changes

src/main/java/digital/slovensko/autogram/server/dto/ValidationResponseBody.java Outdated Show resolved Hide resolved

jsuchal reviewed Dec 6, 2023

View reviewed changes

src/main/java/digital/slovensko/autogram/server/dto/ValidationResponseBody.java Outdated Show resolved Hide resolved

jsuchal requested changes Dec 6, 2023

View reviewed changes

celuchmarek added 2 commits December 7, 2023 10:42

fix typo and minor refactor

f23c0ad

minor refactor and add better documentation for validation api

a7e3696

jsuchal reviewed Dec 7, 2023

View reviewed changes

src/main/resources/digital/slovensko/autogram/server/server.yml Show resolved Hide resolved

add validation api xdc disclaimer and update api version

3d9d388

celuchmarek requested a review from jsuchal December 7, 2023 13:00

jsuchal approved these changes Dec 7, 2023

View reviewed changes

jsuchal mentioned this pull request Jun 24, 2024

Pridať funkcionalitu overovania podpisov slovensko-digital/avm-server#15

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AG-112 API overovanie #352

AG-112 API overovanie #352

celuchmarek commented Dec 6, 2023

celuchmarek commented Dec 6, 2023

celuchmarek commented Dec 6, 2023 •

edited

Loading

jsuchal commented Dec 6, 2023

celuchmarek commented Dec 6, 2023 •

edited

Loading

jsuchal commented Dec 6, 2023

jsuchal commented Dec 6, 2023

celuchmarek commented Dec 6, 2023

jsuchal commented Dec 6, 2023

celuchmarek commented Dec 6, 2023

celuchmarek commented Dec 6, 2023 •

edited

Loading

jsuchal left a comment

jsuchal left a comment

jsuchal commented Feb 27, 2024

AG-112 API overovanie #352

Are you sure you want to change the base?

AG-112 API overovanie #352

Conversation

celuchmarek commented Dec 6, 2023

celuchmarek commented Dec 6, 2023

celuchmarek commented Dec 6, 2023 • edited Loading

jsuchal commented Dec 6, 2023

celuchmarek commented Dec 6, 2023 • edited Loading

jsuchal commented Dec 6, 2023

jsuchal commented Dec 6, 2023

celuchmarek commented Dec 6, 2023

jsuchal commented Dec 6, 2023

celuchmarek commented Dec 6, 2023

celuchmarek commented Dec 6, 2023 • edited Loading

jsuchal left a comment

Choose a reason for hiding this comment

jsuchal left a comment

Choose a reason for hiding this comment

jsuchal commented Feb 27, 2024

celuchmarek commented Dec 6, 2023 •

edited

Loading

celuchmarek commented Dec 6, 2023 •

edited

Loading

celuchmarek commented Dec 6, 2023 •

edited

Loading